For what it's worth, Phabicator has a fairly close match to this workflow in Herald, which allows you to trigger audits/reviews/notifications based on various business rules:
(Phabricator's "projects" are roughly like tags.)
On Aug 23, 2012, at 2:34 PM, Platonides wrote:
On 23/08/12 15:07, Daniel Friesen wrote:
I don't know if I quite like the thought of an evil reviewer bot.
Though it does make me think of a feature I thought of adding to Gareth.
I can't remember why but one day this feature idea randomly popped into mind. Review tagging. Basically things for review can be tagged with a number of tags. For us we may create tags like (parser, api, skin, specialpages, i18n, etc...) and anyone can add these tags to the review item. Now besides making things searchable users can star/watch tags rather than only star/watch individual review items. This means that Gareth could automatically notify you about new commits in a part of MW that you are stalking/obsessed with. ((This is something we have always basically been missing)) By getting reviewers to watch their own area of MW they can automatically jump in to review changes in that area. Without needing to hover over a dashboard of changes or be overwhelmed by notifications of every single commit coming in. And getting your commit reviewed wouldn't be anymore a matter of "Try to find one of the few people in our large community who reviews the topic your commit is in" but instead would be the much simpler "Tag your commit with the relevant topics so that reviewers can see it".
Now, naturally as in the spirit of Gareth I didn't stop there with manual tagging and thought of a rules system to add tags automatically: if filechanged includes/parser/* add tag 'parser' if filechanged includes/api/* add tag 'api' if filechanged (includes/Skin.php, includes/SkinTemplate.php, includes/SkinLegacy.php) add tag 'skin' etc...
We could basically have tags automatically added based on what files were updated in the commit.
Personally I'd probably be hovering over any commit tagged with skin, linker, and a few other tags.
I think we had such support in CodeReview (or at least considered adding it). Having to find out / magically know who to add as a reviewer is a gerrit drawback.
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l