"BV" == Brion Vibber brion@pobox.com writes:
BV> Errr, that's what I shoulda said. This broke quinlan's emacs BV> editing-helper tool which does a direct login submission. I BV> did give him the workaround, though.
OK, yeah. Quickest workaround would of course be to just load another page and get a session cookie.
I've reworked the cookie checking to do a redirect check after login or account creation. If the redirect check fails -- still no cookie -- then it goes back to the login page with an error. If the redirect check succeeds, it just shows the appropriate login success page.
I also added a little login prompt that says that you should have cookies enabled. It seems like a good idea and should cut down on people seeing these errors in the first place.
I tried the new function with these scenarios:
* Log in, existing user, cookies enabled * Log in, existing user, cookies disabled * Log in, existing user, cookies disabled but turned on on login page * GET login, existing user, cookies enabled * GET login, existing user, cookies disabled * New account, cookies enabled * New account, cookies disabled * New account, cookies disabled but turned on on login page
This isn't really a righteous patch. I made the mistake of installing a PHP mode for Emacs, and it mucked around with the formatting, so there's a number of bogus diff lines. I'm too lazy to figure out how to customize this *%^$#! mode to get it to format correctly; hopefully whoever applies the patch can do that.
Hopefully this clears some things up.
~ESP