Sorry for the previous empty mail, I clicked the wrong button.
On Thu, Jun 26, 2008 at 8:21 PM, Simetrical Simetrical+wikilist@gmail.com wrote:
On Thu, Jun 26, 2008 at 2:03 PM, Bryan Tong Minh bryan.tongminh@gmail.com wrote:
FYI, it was setting the whole content of the user entry again, including email and preferences etc. That is what has been replaced by [private data]
I suspected that. Something's wrong here. That query should *not* be running on Wikimedia servers, it's scary and does nothing, and causes needless locking to boot. Perhaps it's the fault of CentralAuth or something: I didn't see any suspects in the API, at a quick glance.
It is. CentralAuthPlugin::updateUser (which is according to documentation called each login) always sets the local email to the global email.
On Thu, Jun 26, 2008 at 2:09 PM, Roan Kattouw roan.kattouw@home.nl wrote:
I'm pretty sure it's not meant to change user_name, it seems to be just a poorly-written query.
It might not be intended to, but it does. I have to wonder if you could get some race conditions if the user is being renamed while trying to log in here, so that this no-op update might actually change the name to something wrong.
It's a todo on User::saveSettings: "@todo Only rarely do all these fields need to be set!"
Bryan