Hi Denny,
I think we may be talking past each other. Comments inline...
On Mon, Aug 13, 2012 at 9:47 AM, Denny Vrandečić denny.vrandecic@wikimedia.de wrote:
I am a bit confused here. As far as I can see everyone agrees that this changeset goes in the right direction.
I don't think enough people actually understand the patch well enough to say that. The fear is that it's a step sideways, trading crufty but well-tested code for something larger, more confusing, and less stable.
I also did not see contentions about how the changeset is working that have not been resolved yet. The reservations that are raised are that the changeset does not go *far enough*. Considering that we want to keep changesets small, and that this changeset keeps the old system in place and thus should not break anything, wouldn't that be a good first step?
It depends. Every time someone asks for specifics ("where is this code used?", "what exactly is this needed for?"), they get very meta answers ("it's used in Wikidata").
If you want to expedite this review, give specific answers. Point to line numbers in files, and show how the code there would be far more complicated without this change. Point to specific functionality we can see in a running instance. Use this as an opportunity to educate everyone on Wikidata internals.
Thanks Rob