On Fri, May 10, 2013 at 8:05 AM, Jeroen De Dauw jeroendedauw@gmail.com wrote:
Hey,
I can see why SPL might require extra work in HipHop to support. At the same time I find it somewhat unfortunate this means one cannot use the Standard PHP Library.
Yeah, but I think it's a workable issue. And the HH team seems very amenable to feature requests (and patches!), so implementing parts of the SPL are certainly possible over the long term.
As Tim points out, for ArrayObject and filter_var() it's non trivial to implement (even Zend's implementation of the former is 2000+ LOC).
Question: Is it possible to use HipHop only for part of a codebase. For instance, if there is some MW extension that depends on a third party library we have no control over that makes uses of SPL, would this cause problems?
I don't think so, as HipHop is a standalone implementation of PHP and doesn't even really know about the php binary/libraries.
Suggestion: If such a policy is implemented, I'd be great to have a job that checks for violations of it on our CI.
This is a very good idea, and something I'll take a stab at handling.
-Chad