Roan Kattouw wrote:
Auto-deferral regexes for CodeReview were implemented in r63277 [1], and I deployed this feature three weeks ago. It allows us to set an array of regexes that will be matched against the path of each new commit; if one of them matches, the commit is automatically marked as 'deferred' instead of 'new'.
It should probably allow different status.
There are a few limitations to this implementation that are important to understand:
- it only matches paths, not commit summaries. This means
auto-deferring e.g. TranslateWiki exports is harder
- it only matches the root path of the commit, which is very often an
uninformative one like /trunk/phase3 , /trunk/extensions , /trunk or even / . This means you can't e.g. auto-defer all commits touching a certain file or path
Why not base it also in $rev->mPaths ? We don't touch so many files for it to be problematic on server resources, and an auto-defer for commits with all files matching "(^/trunk/phase3/languages/messages/|.i18n.php$)" would nicely skip all translatewiki updates.
Although a hook entry may be a more appropiate way.