Hi!
"Test Plan" is required.
Sounds like a good practice to me. Worst case scenario, type "I didn't test this patch at all."
I think it's not a good idea, as it trains people to do the opposite thing of what it's intended to train people for. I.e. "mandatory, but put 'whatever' there" IMHO is worse than non-mandatory but supported by common consensus. If we're setting up a new system, we shouldn't set it up so we constantly work around it.
Neither should you, that is the point of code review. Then again, if there
In theory, this is true. In practice, there are numerous occasions where people have to self-+2 - typoes, forgotten files, CI glitches, rebases, etc. Well, ok, "have to" is a strong word here - all of it can be worked around by dragging in somebody and asking them "please +2 this" - but again, that would be working against the setup and also training people that the system sucks and they have to work around it to be effective.