On Mon, Dec 9, 2013 at 2:15 PM, Gabriel Wicke gwicke@wikimedia.org wrote:
Are you sure this is still the case? https://code.google.com/p/v8/issues/detail?id=2315 seems to suggest that this was fixed in V8 last year.
Not sure if it's related, but looking at the bleeding edge compiler.cc code directly, it explicitly turns off optimizations inside the eval compiler. [0]
On Mon, Dec 9, 2013 at 5:08 PM, Daniel Friesen daniel@nadir-seen-fire.com wrote:
Also are we even using eval anyways?
The module storage stores whole scripts, it should be able to function by inserting inline <script>// downloaded text</script> elements.
It depends. Right now we use $.globalEval(), [1] which will make a <script> element if the Javascript has "use strict" at the very very beginning. Otherwise it just uses eval(). [2]
[0] https://code.google.com/p/v8/source/browse/branches/bleeding_edge/src/compil... [1] https://doc.wikimedia.org/mediawiki-core/master/js/source/mediawiki.html#mw-... [2] https://github.com/jquery/jquery/blob/master/src/core.js#L283
*-- * *Tyler Romeo* Stevens Institute of Technology, Class of 2016 Major in Computer Science