Le 07/03/2014 07:55, MZMcBride a écrit :
Tim Starling wrote:
I would never have merged it, because it had a -1 from Steven Walling, apparently speaking on behalf of others on design-l. I think changes should be made by consensus.
The change also had five +1s, as noted in this thread. I find it interesting that, to you, consensus now includes a liberum veto. I'm fine with a temporary revert if the change was causing an issue in production, but the overall goal and execution seems fine to me.
X oppose and Y approve is not a consensus. X+Y approve is.
So a single -1 should prevent a change from being submitted until that -1 is lifted by addressing the person concern(s) or correcting him/her or whatever.