-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hi,
On 04/07/2018 09:03 PM, Kunal Mehta wrote:
I'd like to start running voting tests against PHPUnit 4 and 6 next week on Thursday (April 12). This should give us just enough time to fix any resulting issues before the 1.31 branch.
We ran into a few[1] issues today, but are all ready to merge the upgrade to PHPUnit 6[2] tomorrow (Friday April 13). I suspect that very few people actually tested their extensions against PHPUnit 6 - so we'll just see what the fallout is and fix broken extensions as they come up. Thanks to Anomie, James F, and Krinkle for addressing failures and reviewing patches today, and Hashar for helping with Jenkins :-)
So far the main problem areas that cause failures are: * Using getMock/setExpectedException without the back-compat layer * Trying to mock methods that no longer exist (or never did) * Tests that don't assert anything and are risky
[1] https://gerrit.wikimedia.org/r/#/q/topic:phpunit-6 [2] https://gerrit.wikimedia.org/r/#/c/394851/
- -- Legoktm