On 11/03/14 20:16, James Forrester wrote:
On 11 March 2014 13:10, Isarra Yos zhorishna@gmail.com wrote:
On 11/03/14 17:26, Trevor Parscal wrote:
It might be easier to revamp the skin system if there were fewer skins to port.
- Trevor
But that completely ignores the primary users of non-Vector skins
Sure, because they aren't in MediaWiki core. Trevor's point is that there are four skins to fix *in the same commit* as fixing the skins system, and this would be a lot easier if there were instead three, or two, or one.
In fact, this is the *reason* we stopped adding new skins to MediaWiki core, and instead they're treated like extensions and sysadmins are expected to pay attention to breaking changes.
The wider question about fixing "once and for all" the changes to skins is out of scope for this discussion, and would involve some serious thought, but that's something that can be done regardless of whether Cologne Blue is in core. It'd just make it easier.
J.
Because they aren't in core, my point is that people forget they exist at all. They shouldn't do that.
But yes, having to fix them all in one commit is silly. More on that elsewhere.
-I