On Tue, Nov 30, 2010 at 10:19 AM, Chad innocentkiller@gmail.com wrote:
On Tue, Nov 30, 2010 at 10:04 AM, Chad innocentkiller@gmail.com wrote:
Hi everybody,
It's kind of silly when we commit php syntax errors to SVN (I've done it too). Of course we should all test our code before committing, but sometimes we don't--especially when it's a one line change and there's No Way It Could Break.
To help us stop making these silly mistakes (and to avoid the inevitable complaint and followup), I've added a pre-commit hook to SVN.
All changed/added files ending in .inc/.php/.php5 are now checked with php -l prior to the transaction completing. You should get a fun error message on your local console if you commit bad code :)
Let me know if you have any problems with it.
-Chad
Disabled temporarily, I'm hitting issues when doing a svn del.
-Chad
Syntax errors in the pre-commit file.
Oh the irony.
-Chad