On 8/11/09 12:45 PM, dan nessett wrote:
--- On Tue, 8/11/09, lee wordenwonder@riseup.net wrote:
Placing it in the include path could make it hard to run more than one version of the MW code on the same server, since both would probably find the same file and one of them would likely end up using the other one's $IP.
That is a good point. However, I don't think it is insurmountable. Callers to MWInit() could pass their path (which they can get calling "realpath( '.' )"). In a multi-MW environment MWInit() could disambiguate the root path by searching the provided path against those of all installed root paths.
Another way of putting it is, is it really better to hard-code the absolute position of the MW root rather than its position relative to the files in it?
Well, I think so. Hardcoding the absolute position of the MW root occurs at install time. Using file position dependent code is a development time dependency. Files are not moved around once installed, but could be moved around during the development process. So, bugs that depend on file position are normally not caused by installation activity, but rather by development activity.
Dan
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
What seems to be being discussed here are particular offensive areas of MediaWiki - however if you really get to know MediaWiki you will likely find tons of these things everywhere... So are we proposing a specific change that will provide a solution to a problem or just nit-picking?
I ask cause I'm wondering if I should ignore this thread or not (an others are probably wondering the same) - and I'm sort of feeling like this is becoming one of those threads where the people discussing things spend more time and effort battling each other than just fixing the code.
- Trevor