On 11-01-12 03:17 PM, Platonides wrote:
Brion Vibber wrote:
On Wed, Jan 12, 2011 at 5:53 PM, Jeroen De Dauwjeroendedauw@gmail.comwrote:
Hey,
I think<display map> would be parsed as the tag hook "display" with a
parameter "map"="map". Would this prevent any use of the hook registered as the tag "display map"...?
This code has been there for a few months now, and appears to be working as expected. The tag extension gets handled properly and no "map" parameter is passed along.
That seems highly contrary to expectations when dealing with tag hooks. What if there's a tag hook "display" registered by another plugin, does it get overridden? Overridden only if a "map" parameter is supplied?
-- brion
It is order dependant. If you install the extension providing 'display', then the one providing 'display map', the latter will never be called. If 'display map' gets registered first, both will work (your users might get annoyed, though).
Guess what I tried to do in r80025? :)
<tag name>...</tag name> Definitely sounds like something we shouldn't support. That kind of thing just screams "you're at the mercy of whatever developer in the future decides to change the parser to 'actually' parse out xml tags with more xml or html-like parsing, instead of simply doing a search and replace based on a list of tag names". Not to mention it's confusing and counterintuitive in articles themselves. What if the <display> tag actually supported a map argument? <display map foo> gets treated as a <display map> tag, but <display foo map> gets properly treated as a <display> tag? bleeeeech... And I have to feel sorry for the users that actually understand any small level of xml or html that are looking at <display map> in a random page and reading that as a tag with the tagName 'display'.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]