On Sat, 2005-12-03 at 13:41 -0800, Brion Vibber wrote:
Evan Prodromou wrote:
I made a late checkin on the 1.4 branch today.
I've reverted it for the moment. Could you check it into the mainline development branch please?
Done.
If it looks ok and doesn't break the actual called hook functions (or if it does, and we have some warning to fix them first), *then* go ahead check it into REL1_4.
OK, I've checked the change in to HEAD, and I've re-tested to my own satisfaction (ran over all the places in the code where events are raised, trying to vary as many things as I could). I've also added a bug report:
http://bugzilla.wikimedia.org/show_bug.cgi?id=1694
I'll merge back to REL1_4 after a few days if I don't hear screams of bloody murder anywhere. Let me know if you want to do some more formal acceptance criteria.
~Evan