Hello again!
Writing to inform that the move has happened. Here's a quick breakdown:
- GitHub repo: https://github.com/wikimedia/wikipedia-ios - Main repo for development, code review, and continuous integration (via Travis & CodeCov) - Gerrit repo: https://gerrit.wikimedia.org/r/#/admin/projects/apps/ios/wikipedia - Code drops every release, developers will still get notifications from patches submitted - *new* Phabricator repo: https://phabricator.wikimedia.org/diffusion/APIOS/ - Automatically synced with GitHub (Phab is the slave). Mostly just as "redundant storage," not sure if we'll support any code review here for the time being (mostly due to iOS team unfamiliarity)
Hope to see a pull request (or patch) from you soon!
Brian
On Fri, Jul 24, 2015 at 10:25 AM, Brian Gerstle bgerstle@wikimedia.org wrote:
FYI, spent some time this morning "refactoring" the epic https://phabricator.wikimedia.org/T98970, scope has been reduced to CI (moving CD into its own epic https://phabricator.wikimedia.org/T102547) and clarified/elaborated many other sections.
On Thu, Jul 23, 2015 at 3:14 PM, Brian Gerstle bgerstle@wikimedia.org wrote:
The (rough) epic definition is already on Phabricator: https://phabricator.wikimedia.org/T98970.
I've defined some metrics there already, but admittedly—and thanks for calling us out on this—we don't really have baselines*. I think there are some feasible ways to get a rough starting point, which I can brainstorm w/ the team. We were planning (or I should say, I was hoping) to gather more code metrics anyway, so I'm glad to have an excuse to hook it up sooner ;-).
FWIW, I also think having patches tested as part of code review https://github.com/bgerstle/apps-ios-wikipedia/pull/3 would also work as a sufficient definition of success. Our goal here is to do that as quickly, easily, and cheaply as possible so we can get back to focusing on the app.
- I think it's fair to say that the coverage at point of migration was
already low (~10% based on my Travis-covered fork) and hasn't changed much.
On Thu, Jul 23, 2015 at 2:04 PM, Greg Grossmeier greg@wikimedia.org wrote:
Brian and the Reading team:
On Wed, Jul 22, 2015 at 3:40 AM, Brian Gerstle bgerstle@wikimedia.org wrote:
By using GitHub with Travis CI, the team believes it will work faster, improve testing, grow developer confidence in making code changes, and, most importantly, deploy fewer bugs to production.
Given that, I am requesting you/your team create a set of KPIs to review in 3 or 4 months to determine if this change had the intended outcome. It's hard to make these things quantifiable as useful KPIs (that prevent eg gaming the system) but I think it'd be a good exercise for your team given your team's decision making process thus far.
Please post those KPIs somewhere public and trackable (wiki or phab).
Thank you,
Greg
-- Greg Grossmeier Release Team Manager
-- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle
-- EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle IRC: bgerstle