On 6/19/05, Timwi timwi@gmx.net wrote:
Ævar Arnfjörð Bjarmason wrote:
First of all I'd like to remove the patch keyword
I was the one that put it in originally. I copied the concept from LiveJournal: someone attaches a patch and sets the 'patch' keyword; other developers search for bugs with the 'patch' but not 'reviewed' keyword; they look at the patches, test them, make sure they work, make sure the code is clean and everything, and add the 'reviewed' keyword. Developers with CVS access look for 'patch'+'reviewed', commit the patches and set the bug to RESOLVED FIXED.
I know I don't have much say in this anymore because I'm not as active as I used to be, but I would nevertheless prefer if the 'patch' keyword would stay (and MediaZillians would set it appropriately). There is no way to search for patches otherwise (see below).
Might a flag be better for the review part? from the bugzilla docs:
""" Flags are markers that identify whether a bug or attachment has been granted or denied some status. Flags appear in the UI as a name and a status symbol ("+" for granted, "-" for denied, and "?" for statuses requested by users).
For example, you might define a "review" status for users to request review for their patches. When a patch writer requests review, the string "review?" will appear in the attachment. When a patch reviewer reviews the patch, either the string "review+" or the string "review-" will appear in the patch, depending on whether the patch passed or failed review. """