Le 07/03/12 10:43, Niklas Laxström a écrit :
- I spend around 10 hours a week reviewing code (this is going to be
much more difficult)
Here how one would start his code review day:
Load the Gerrit main interface. In the search box at the top right, enter your favorite project. For example: mediawiki/core The change list is now filtered.
Blame Gerrit for showing the sha1 instead of change number.
Then:
# Fetch change you are interested in: $ git review -d 1234
# Diff against gated trunk master branch: $ git diff origin/master
From there you can edit the patchset, even if it was submitted by
someone else. Then reuse his commit message and edit it!!
$ git commit -a --amend <append something like: patchset2: fixing typo by someone> $ git review -f # submit and then delete (-f) local branch
Repeat.
Sometime you get interrupted when doing a review. You could then git commit your current review progress then fetch another change to review / merge. You will then be able to come back to where you where at during review.
Anyway, that is a slightly different workflow, but eventually we will all get used to it. It is not harder than subversion and it is even a bit quicker :)