On Thu, May 8, 2008 at 2:33 PM, catrope@svn.wikimedia.org wrote:
Revision: 34431 Author: catrope Date: 2008-05-08 12:33:20 +0000 (Thu, 08 May 2008)
Log Message:
API:
- Added ApiQueryBase::addJoin() which provides a cleaner interface to construct JOIN queries. Behind the scenes this still uses the old, ugly way, but it'll be easy to rewrite when/if the Database class gets its own function for JOINs
- Used addJoin() in query modules where necessary
- Removed FORCE INDEX (rc_timestamp) from ApiQueryRecentchanges: it's nigh impossible to integrate with addJoin() and it doesn't seem to be necessary anyway (my MySQL instance automatically chooses rc_timestamp)
I've heard rumours on #wikimedia-tech that MySQL 4 sometimes chooses the wrong index unless forced. So I don't know whether this actually works.
Bryan