It's the exact same yellow as before, guys. The *exact* shade.
This is the exact definition of a "bikeshed" argument. Feel free to move along.
On 12/22/11 10:33 AM, Erwin Dokter wrote:
I'd like to ask for more eyes and participation in an issue that is in an apparent stalemate.
It all started with revision 105280 (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280), where Hashdar commited a new color scheme for diffs based on the French scheme. When this generated some flack for making "green the remove-color", I submitted a patch that reversed the colors (https://bugzilla.wikimedia.org/show_bug.cgi?id=33139). This was met with general approval.
Before it could be applied though, Brandon steps in with another patch (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/106884) that mixed the old yellow with the new blue, that looks absolutely horrible; a view in which I am not alone. I immediately submitted a new patch that adjusted the colors and levels, which is now under discussion.
However, today Hashdar closed my bug/patch as Resolved, as he considers the matter closed. As the matter is clearly not, I reopened it. Now I would like to invite as many devs as possible to chime in at r106884 (3rd link) to evaluate the various options. Because if the current revision stands, and subsequently makes in into MediaWiki, we will have a default diff color scheme that will generate a guaranteed backlash form any project that uses MediaWiki.
I'm not one to complain fast, but I now understand why develpers without commit access just turn around and walk away; if submittd patches that have approval are summarily overruled by those with commit access, there is really no point in continueing to submit patches.