Hey,
For some reason DatabseBase::select is returning false sometimes when it encounters a database error rather then throwing an error as you'd expect since it's documented to always return a ResultWrapper. I ran into this issue several times as getting the rather obscure error "expected ResultWrapper, got boolean" in random places using this result. Calling lastError on the DatabaseBase object clearly shows there in fact was an SQL error.
I have all SQL debug settings I'm aware off on:
$wgShowSQLErrors = true; $wgShowDBErrorBacktrace = true; $wgDebugDumpSql = true;
Plus the usual bunch of dev settings.
So this smells like a regression to me, or something that always was broken but not noticed due to people not using type hinting. Anyone an idea where this is coming from? I had a look but it's not clear to me.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --