Sounds good to me.
Jelte-2 wrote:
Op Saturday 17 May 2008 18:10:58 schreef Brion Vibber:
aaron@svn.wikimedia.org wrote:
$limit = $wgRequest->getInt( 'limit', 50 );
global $wgFeedLimit;
if( $limit > $wgFeedLimit ) {
$limit = $wgFeedLimit;
}
This is a good candidate for refactoring into a common function...
How about $limit = min( $limit, $wgFeedLimit ); or $limit = min( $wgRequest->getInt( 'limit', 50 ), $wgFeedLimit ); ?
Jelte
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l