Hi,
TL;DR: Gerrit would allow to keep Code-Review votes across * rebases and * commit message modifications of patch sets.
Thereby dropping need to re-review “trivial” changes on patch sets.
Shall we turn that feature on?
-------------------------------------------- Longer version.
Currently, upon uploading a new patch set for a change in gerrit, votes get scrubbed. Especially, all Code-Review votes except -2 are gone.
However, for new patch sets that * are a plain rebase, or * only change non-code parts (commit message, ...) gerrit would allow to reapply votes of the previous patch set to the new patch set.
People asked me to turn this feature on gerrit-wide for the Code-Review label.
But I would not want to turn it on without giving people a chance to discuss it beforehand.
So ... example: Assume for a given change the current patch set's votes are:
+-------------+-------------+----------+ | Reviewer | Code-Review | Verified | +-------------+-------------+----------+ | Foo | +2 | | | Bar | | +1 | | Baz | +1 | -1 | | Qux | -2 | | | jenkins-bot | | +2 | +-------------+-------------+----------+
Assuming we turn the feature on in gerrit, and I upload a plain rebase of the current patch set, the votes for the plain rebase would be
+-------------+-------------+----------+ | Reviewer | Code-Review | Verified | +-------------+-------------+----------+ | Foo | +2 | | | Bar | | | | Baz | +1 | | | Qux | -2 | | | jenkins-bot | | | +-------------+-------------+----------+
right after uploading the rebase to gerrit (instead of the current behaviour of an empty table with only Qux CR-2). Same if I only edit the patch set's commit message.
But if I upload a patch set that is changing the patch set's diff, the table of votes would of course still get scrubbed of all votes except -2 on Code-Review (as it also the case right now):
+-------------+-------------+----------+ | Reviewer | Code-Review | Verified | +-------------+-------------+----------+ | Foo | | | | Bar | | | | Baz | | | | Qux | -2 | | | jenkins-bot | | | +-------------+-------------+----------+
Should we turn that feature on?
Best regards, Christian