On Thu, Nov 3, 2011 at 8:42 PM, Brion Vibber brion@wikimedia.org wrote:
On Thu, Nov 3, 2011 at 12:23 PM, Brion Vibber brion@wikimedia.org wrote:
In r101860 I've removed most of the client-* classes from the <html> that were added based on user-agent sniffing. Sniffing UA strings is a fragile practice which should be strongly discouraged in favor of checking for
the
actual features or bugs that you need to address -- encouraging people to use styles like "client-firefox7" makes me feel a little ill inside. :)
Sounds good.
On a related note I took a quick peek over some of the other uses of jquery.client.js, through $.client.profile() direct checks or $.client.test() with a compatibility map.
I'm proposing swapping the direction of the compatibility maps to make them a little easier to read and maintain: < https://bugzilla.wikimedia.org/show_bug.cgi?id=32188%3E
That has been confusing be from the beginning. I stumbled across it when looking for code to cover in unit tests. Decided to skip that function for the time being. This will ease it up.
-- Krinkle