Wouldn't it be simpler to just compare the Wikimedia version? if version < 1.21 { Don't use ContentHandler }
*--* *Tyler Romeo* Stevens Institute of Technology, Class of 2015 Major in Computer Science www.whizkidztech.com | tylerromeo@gmail.com
On Thu, Oct 11, 2012 at 1:03 PM, Victor Vasiliev vasilvv@gmail.com wrote:
On 10/11/2012 09:56 AM, Daniel Kinzler wrote:
On 10.10.2012 23:37, Rob Lanphier wrote:
I'm very worried about converting all of the extensions to use new APIs now. If it turns out we need to revert ContentHandler, this will make the revert that much more difficult.
I'd rather we remove deprecation warnings for the newly deprecated APIs.
Ok. I discussed this a bit with Tim, and we came to the following conclusion:
- Don't update the extensions for a while. But make sure we do eventually.
- Disable the deprecation warnings for now by using
ContentHandler::deprecated() instead of wfDeprecated(), so we have a single place to enable or disable these warnings.
- Define MW_SUPPORTS_CONTENT_HANDLER for easy B/C switches in extensions.
-- daniel
______________________________**_________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l
I think instead of using individual constant, we should finally introduce a Capabilities class.
It should have a single static method, has(), which indicates whether a certain capability is registered within the system. At the beginning, capabilities will be listed as static members of that class, but we may do something more clever at the future.
I would also suggest that we introduce a policy of adding a capability for any new hook we add. Or we could parse docs/hooks.txt in order to avoid duplication (probably moving it somewhere).
Finally, backporting that interface into previous versions of MediaWiki might be a good idea.
—Victor.
______________________________**_________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l