Great and thanks! After I fix this I will have all of the tests in /tests/ working (it turns out there are 6 not 7 tests - one of the .php files only held an abstract class).
--- On Tue, 8/4/09, Brion Vibber brion@wikimedia.org wrote:
From: Brion Vibber brion@wikimedia.org Subject: Re: [Wikitech-l] getThumbVirtualUrl() behavior To: "Wikimedia developers" wikitech-l@lists.wikimedia.org Date: Tuesday, August 4, 2009, 4:51 PM On 8/4/09 11:22 AM, dan nessett wrote:
- testGetThumbVirtualUrl(LocalFileTest) Failed
asserting that two
strings are equal. expected stringmwrepo://test/public/thumb/Test%21
difference<
xxxxxxxxxxxxx???????> got
stringmwrepo://test/thumb/Test%21 [snip]
Obviously, the function is coded to return something
different than
the test expects. The problem is, I don't know if this
is a bug in
the test or in the code.
Looks like an old test that needs to be updated. IIRC Tim recently changed the system to use a separate virtual path for thumbs so we can easily configure the system to store thumbs in a different path (and hence different file server) from the primary media files.
-- brion
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l