Hi Legoktm,
On Sun, Jun 21, 2020 at 06:10:58PM -0700, Kunal Mehta wrote:
On 2020-06-20 14:58, Christian Aistleitner via Wikitech-l wrote:
[ gerrit-test.wikimedia.org ]
Just to clarify, it's safe to log into the test instance to change things, right?
Right.
I mainly want to make sure wikibugs can still parse the stream-events feed properly.
Awesome!
Also, do you know if any changes are expected to Gerrit's email notifications?
Only, minor, subtle differences. Nothing that we'd notice I hope.
I primarily use the List-Id header and [...]
List-Id should be the same on both versions. Well, the ending is obviously different. It's gerrit-test.wikimedia.org for gerrit-test.wikimedia.org and gerrit.wikimedia.org for gerrit.wikimedia.org.
So it's
List-Id: <gerrit-mediawiki-core.gerrit-test.wikimedia.org>
for gerrit-test.wikimedia.org and
List-Id: <gerrit-mediawiki-core.gerrit.wikimedia.org>
for gerrit-test.wikimedia.org.
the Gerrit-* pseudo-headers at the bottom of notifications for filtering.
The `Gerrit-*` pseudo-headers at the bottom should hold the same content, but judging from test emails, they got reordered a bit. For example, Gerrit-MessageType was rather at the beginning of the block, while it is now near the end. But I'm not exacly sure if that order was ever consistent before. If it's relevant, let me know and I'll dig into Gerrit's email code.
Other than the above, the most noticeable change for me was that Gerrit now more consistent with Message-ID headers. Since we use a proper mail-server, this means that we'll likely see less messages that come with a @mx1001.wikimedia.org Message-ID. But that's a more lengthy discussion. If that's relevant for you, I guess it's better to discuss that off-list.
Have fun, Christian