On 03/06/2014 09:58 PM, Tyler Romeo wrote:
I don't think you see the problem here. Consider this case as an example (I agree that this is case-by-case, so let's limit the scope to this one). You're forgetting that the original patch fixes a bug. In fact, it fixes a pretty serious UX bug in my opinion (and many others who supported merging this patch).
It's a UX deficiency some users care about and some others (I wanted 'lower case' and it gave me 'Lower_case') don't (or much less) (https://bugzilla.wikimedia.org/show_bug.cgi?id=61416).
It's not a straightforward bug, but a series of design tradeoffs.
It is a clear issue that it caused a MobileFrontend test failure (and the connected negative UX impact). Changes should never cause test failures in an ideal world (either change the test or don't merge the code), but in this case it's understandable with the status quo since it was in a different repo and did not run pre-merge.
So to summarize, #3 is obviously not an option. For #2, are we supposed to block core development, and let this bug persist indefinitely, because of a much less serious bug in an extension?
No one's saying 'indefinitely', just to come to a consensus and test with mobile.
Matt Flaschen