On Tue, Dec 21, 2010 at 12:36 PM, Brion Vibber brion@pobox.com wrote:
Tell you what -- 10 uses of opendir shouldnt take too long to replace; write the code and let's see how it actually looks. Us all sitting in the list bikeshedding won't be much use, but if it makes the code cleaner, hey win!
-- brion
Well it's in trunk now[0] (plus a few followups). It's shorter, yes. Some profiling before/after would probably be good.
-Chad
[0] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78903