On Tue, Aug 5, 2008 at 10:18 PM, dantman@svn.wikimedia.org wrote:
Revert r38675: This commit was clearly not thought out and poorly implemented.
- The Sanitizer has not been used
- Proper implementation of this would follow the same convention as the other classNames and have a 'skin-' prefix
Consistency in the code organization wasn't even kept, a bit of code was just lazily tacked onto the end of another line.
The Sanitizer doesn't need to be used, since any valid PHP identifier is a valid CSS class. The point about the prefix is valid. Also, we need to carefully think about how many new classes we want to spam onto the body element. What's the use-case here? CSS is loaded conditionally based on skin already, and for JavaScript I'm pretty sure it's already provided in a variable.