Re: [Wikitech-l] [MediaWiki-CVS] SVN: [34169] trunk/phase3

From: vasilievvv@svn.wikimedia.org vasilievvv@svn.wikimedia.org Date: May 3, 2008 3:09 PM Subject: [MediaWiki-CVS] SVN: [34169] trunk/phase3 To: mediawiki-cvs@lists.wikimedia.org

Revision: 34169 Author: vasilievvv Date: 2008-05-03 13:09:34 +0000 (Sat, 03 May 2008)

Log Message:

• (bug 709) Cannot rename/move images and other media files.

Currently in experimental mode, use $wgAllowImageMoving to enable it. Known issues:

• Doesn't work with rev_deleted
• May also have some security and caching issues.

[...]

•                           if( preg_match( '/^(\d+)px-/', $file,
  

$matches ) ) {

•                                   list( $unused, $width ) = $matches;
  

•                                   $this->thumbs[] = array(
  

•                                           $thumbDirRel . '/' . $file,
  

•                                           $newThumbDirRel . '/'
  

. $width . 'px-' . $this->newName

•                                   );
  

•                           } else {
  

•                                   wfDebug( 'Strange file in
  

thumbnail directory: ' . $thumbDirRel . '/' . $file );

•                           }
  

I don't know whether it is correct to assume that all files are /^(\d+)px-/. Subclasses of MediaHandler::makeParamString may return an arbitrary prefix not limited to /^(\d+)px-/. I think it is safest to simply move all files in the directory to the new location.

[...]

•   function addOlds() {
  

•           $archiveBase = 'archive';
  

It may be better to use File::getArchivePath() here.

---

MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Looks all very promising :) I hope that we get this working soon!

Bryan