On Nov 6, 2003, at 17:04, Dave Caroline wrote:
Been lurking for a while would like to join in!
Welcome!
Found a few bugs already! $_SERVER
php does not guarantee I quote "You may or may not find any of the following elements in $_SERVER." and then lists constants. 'HTTP_ACCEPT_CHARSET' seems to be missing in my test environment.
If the header's not there we get a blank and use a default value. If your PHP error reporting settings are insanely strict it may complain about this idiom and unnecessarily spam the error log; take E_NOTICE out if you've got it on. See: http://us4.php.net/manual/en/phpdevel-errors.php#internal.e-notice
It's not strictly necessary to explicitly check with isset() or empty() here, but it is good programming style; please feel free to submit a cleanup patch!
(Do you have a sourceforge account?)
Update install notes in phase3 to mention the include_once bug in php/windows (fix code to avoid in future). It took me ages to find out about this. I only stumbled accross this in meta after a long persistent search.
I'm not familiar with this bug (or any other Windows eccentricities PHP may have), can you explain?
-- brion vibber (brion @ pobox.com)