On 2013-11-04 11:04 AM, "Brad Jorsch (Anomie)" bjorsch@wikimedia.org wrote:
On Fri, Nov 1, 2013 at 6:43 PM, Brian Wolff bawolff@gmail.com wrote:
I haven't looked at your code, so not sure about the context - but: In general a hook returns true to denote no futher processing should take place.
If we're talking about wfRunHooks hooks, the usual case is that they return *false* to indicate no further processing, and true means to *continue* processing.
-- Brad Jorsch (Anomie) Software Engineer Wikimedia Foundation
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
D'oh. You are of course correct. Sorry for the mistake.
As an aside, perhaps we should introduce constants for this. Its easy to mix up the two values.
-bawolff