On Fri, Sep 5, 2008 at 6:11 AM, Tim Starling tstarling@wikimedia.org wrote:
[snip]
The technical details were as follows: I fixed a bug in File.php, and without checking what other changes were made to it, deployed the most recent version of the file on the Wikimedia servers, without also updating the rest of MediaWiki. Because FileRepo::$thumbDir was unset, LocalFile::migrateThumbFile() had the effect of deleting the source image for any thumbnail request which reached the backend. I reverted the change after about 20 minutes, following a report on IRC.
My sincere apologies.
-- Tim Starling
foundation-l mailing list foundation-l@lists.wikimedia.org Unsubscribe: https://lists.wikimedia.org/mailman/listinfo/foundation-l
And mine as well. I introduced the $thumbDir code in r40385. I thought I had set a sane default of 'thumb/' in the constructor (which would work per current behavior of using hardcoded 'thumb/'. Is there a code-path in which $thumbDir isn't being set? If so, that needs fixing asap. Would a revert be in order, or is everything ok as-is?
-Chad