Diederik van Liere wrote:
Roan Kattouw wrote:
Yes, ops essentially uses a post-commit workflow right now, and that makes sense for them.
ops also uses pre-commit review for non-ops people :-]
Yeah, that's right. What I meant to say (and thought I had said in some form later in that message) was that the puppet repo has post-commit review for most changes by ops staff, and pre-commit review for everything else (non-ops staff, volunteers, and certain changes by ops staff in some cases).
I became curious with these statements regarding self-review (committer==reviewer) and so I ran a couple of queries against the gerrit database to see how often this occurs:
- For the puppet repo, 84.1% of the commits is self-reviewed.
- For the mediawiki core repo, 27.9% of the commits is self-reviewed.
- For the mediawiki extensions repos, 67.8% of the commits is self-reviewed.
Queried the database how?
Including the queries themselves is usually profoundly helpful in discussions such as these.
MZMcBride