On Tue, 27 May 2014 05:28:41 +0200, Dan Garry dgarry@wikimedia.org wrote:
I am not a developer and therefore I cannot speak for them, but from a product perspective I have no insurmountable issues with either the /skins/ or the /extensions/ solution. It seems that there's pros and cons for each solution, so as long as it's handled appropriately (and it certainly seems to me like you're doing that), then you've got my support.
So, I'm proposing an experiment: We can evaluate this almost painlessly by converting the current Nostalgia extension-skin to a skin in my proposed format, deploying it on nostalgia.wikimedia.org (after doing whatever changes are necessary to deployment things first) and seeing what happens.
Well, you've got my endorsement! How can I help you make this happen?
It just so happened that Chad has recently merged a parallel set of changes that moved two skins out of core – Modern and Cologne Blue (https://gerrit.wikimedia.org/r/#/c/118345/ and linked patches) – and today he submitted patches that would make it possible to deploy the two new repositories in the skins/ directory. (Thanks Chad!)
See https://bugzilla.wikimedia.org/show_bug.cgi?id=65868 about the progress.
This is going to roll out with tomorrow's deployment and should be unnoticeable for users.