On 25 October 2012 08:07, Tyler Romeo tylerromeo@gmail.com wrote:
So recently https://gerrit.wikimedia.org/r/15746 was merged. It implements a pretty timestamp function. Yet it was somehow completely ignored that we actually have an MWTimestamp class made specifically for timestamp objects in MediaWiki.
It does use wfTimestamp in many places.
If you are saying that the new functionality should be in the MWTimestamp class, then I disagree. wfTimestamp and MWTimestamp have never* contained anything else but code which parses and formats timestamps in various different formats used in databases, http protocol, image files, etc. This is clearly visible from the design of the class, it doesn't take any kind of context for the language or user to affect the formatting
Language class has always been responsible for formatting time and date expressions for users.
* Well, not until someone added getHumanTimestamp which I guess should be deprecated now.
-Niklas