On 15.01.2013 12:58, Nikola Smolenski wrote:
In my opinion, if the typo is trivial (f.e. someone typed "fo" instead of "of"), there is no need to -1 the commit, however if the typo pertains to a crucial element of the commit (f.e. someone typed "fixed wkidata bug") perhaps it should, since otherwise people who search through commit messages won't be able to find commits that contain word "wikidata".
Ok, full text search might be an argument in some cases (does that even work on gerrit?).
But in that regard, wouldn't it be much more important to enforce (bug 12345) links to bugzilla by giving a -1 to commits that don't have them (though they clearly have, or should have, a bug report?)
I'm still in favor of requiring every tag line to contain either (bug nnnnn) or (minor), so people are reminded that bugs should be filed and linked for anything that is not trivial. That's not what I want to discuss here - it just strikes me as much more relevant than typos, yet people don't seem to be too keen to enforce that.
-- daniel