On 13 October 2010 10:54, Trevor Parscal tparscal@wikimedia.org wrote:
3. 3 out of 5 code reviewers are voting that it should be merged into core (Brion and Tim have not weighed in yet).
Does it matter if one is one of the six persons that were lately assigned to do code review or not? Did the earlier announcement suddenly give more weight to their opinions? In my opinion things like this does not help in getting other people (volunteers) to help with the code review, which is something Danese was planning to do - unless I remember incorrectly.
I've previously indicated my support of merging the working parts of the Vector enhancements to core. Sure it is more code for the new release and the merge can cause bugs, but on the other hand those really seem to be useful to lots of people. I also think that confused sysadmins are less happy than sysadmins who have to do changes but are not so confused. It takes more time to figure out what is what and why something is not working than do the actual changes.
-Niklas