On 31/08/2007, Erik Moeller erik@wikimedia.org wrote:
There were some issues with the code that Paa Kwesi committed, and I've asked him to fix those.
Why wasn't this worked on in the branch beforehand? If it's in a branch in our repository, there are the benefits of ongoing peer review (because everyone who gets a commit notification is likely to glance at it, at least), it makes merging things easier when the time comes, etc.
a) shortly before release
Perhaps it would be wiser to simply not include it in the release branch if that is a problem?
This requires additional fiddling, and means the release branch isn't a pure branch in the classic sense. It creates more work for the release manager, and sets an odd precedent.
Rob Church