On 09.08.2012 16:49, Rob Lanphier wrote:
On Thu, Aug 9, 2012 at 6:54 AM, Denny Vrandečić denny.vrandecic@wikimedia.de wrote:
- Merging the Wikidata branch (ContentHandler) is still open, see
https://bugzilla.wikimedia.org/show_bug.cgi?id=38622. There has been no feedback in the last few weeks. Daniel is waiting for input.
Per discussion on the bug, there's an unresolved issue with the code as stored in Gerrit. Tim tried cloning this, and wasn't able to find some of the revisions that Daniel referred to.
That would be strange, a straight fresh clone works fine for me, the revisions are in the log.
Tim, please confirm that you are unable to see the changes I mentioned when you just switch to the Wikidata branch on an up to date working copy of core, ignoring Gerrit.
Also, dennyb added direct links to the respective commits on gitweb. They are there. Gerrit just doesn't know about it. And the shortlogs on gitweb are strange.
Last week, you mentioned that Daniel was going to send mail to the list about the Gerrit stuff, but I don't recall seeing that.
I investigated the problem and reported my findings on bugzilla. There isn't muchz to say except "gerrit doesn't know about direct pushes" and "gitweb is confusing".
If you can get the code somewhere Tim can review it, he's ready to look at it.
Well, it's in the git repo. Everyone in the team is using that branch for development and testing, they'd notice if important changes were missing. So i'm confident that it really *is* there.
-- daniel