I've added a poll in the task description as an attempt to get a synthetic view of who is volunteer to review.
You can vote at https://phabricator.wikimedia.org/T128371 or directly at https://phabricator.wikimedia.org/V9.
On Tue, Mar 29, 2016 at 11:22 PM, Greg Grossmeier greg@wikimedia.org wrote:
Changing subject to focus on the code-review office hours idea.
Also, a request at the end for people with +2 to indicate if they would be willing to participate in an experiment or not :)
<quote name="Jon Robson" date="2016-03-16" time="15:47:49 -0700"> > We have two swat windows every day. It's magical... I post a request for a > deploy on a Wiki page and someone deploys it.
:) glad you like it
Could we try a similar thing with code review. Code review window (maximum 1 patch per person) and have a group of +2ers look at a maximum set of patches?
It would need a few more rules than that and a bit of tweaking but seems like a good experiment. I'd sign up to help it if it was a maximum 2 windows for me a week.
That sounds like an interesting idea indeed, Jon.
An action item from me from the DevSummit was https://phabricator.wikimedia.org/T128371, which is basically "setup code-review office hours" without much more detail than that (it was a drive-by idea during one of the sessions that I volunteered to follow-up with).
My initial idea was very minimal (basically just a time and a virtual place to do code-review together) but adding in the explicit support of +2ers helping merge ready patches during the time gives it more effectiveness.
The hardest part will, I assume, be getting enough people with commit rights to volunteer for at least one day/week.
Any one reading this far with +2 willing to? If so, please comment on the task (to save the mailing list): https://phabricator.wikimedia.org/T128371
Thanks,
Greg
-- | Greg Grossmeier GPG: B2FA 27B1 F7EB D327 6B8E | | identi.ca: @greg A18D 1138 8E47 FAC8 1C7D |
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l