tlaqua@svn.wikimedia.org wrote:
- Making unmergable user ID(s) configurable rather than assuming ID 1 (on recommendation from Simetrical)
- Now allows defining unmergable users by ID or user_name
Hmm, I notice a couple issues here still.
First, there's no blanket prohibition on numeric usernames in MediaWiki (though some blacklist extensions forbid it). The weak comparisons here will match both ID numbers *and* names, which may be a little odd.
Second, setting the default at 1 is a bit arbitrary and imho not a great idea.
It probably would be cleaner to set the default limit by group membership or permission key, since there's not necessarily anything unique or special about id 1, and have the explicit user blacklist be by username only for easier management.
-- brion vibber (brion @ wikimedia.org)