sorry forgot to remove the ! in the fix ...doh...
should be:
function isValidPassword( $password ) { global $wgMinimalPasswordLength, $wgContLang;
$result = null; if( wfRunHooks( 'isValidPassword', array( $password, &$result, $this ) ) ) return $result;
On 9/21/07, Thomas Dalton thomas.dalton@gmail.com wrote:
anyway: function isValidPassword( $password ) { global $wgMinimalPasswordLength, $wgContLang;
$result = null; if( !wfRunHooks( 'isValidPassword', array( $password, &$result,$this ) ) ) return $result;
should be: function isValidPassword( $password ) { global $wgMinimalPasswordLength, $wgContLang;
$result = null; if( !wfRunHooks( 'isValidPassword', array( $password, &$result,$this ) ) ) return $result;
I don't see any difference...
However, I think it is correct. Hooks should return true if the code should keep going and run other hooks and the rest of the standard code, and false if it should stop there.
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l