On Thu, Mar 8, 2012 at 4:03 PM, Platonides Platonides@gmail.com wrote:
I like Gerrit diff system. Yeah I know that sounds like trolling read below though before discarding this mail.
Sure, inline comments are cool but I think they lack discoverability. You need to browse all the diffs just in case there's a lonely inline comment there.
Suppose hashar commits c1234. Ahar Voultoiz reviews a couple of files and adds an inline comment 'This feature is PHP 5.4 only' Then Antoine Musso does git review -d 1234, finds it fine and approves it.
I think inline comments should also produce entries at the comments section.
The change's initial view tells you which files have comments, and how many comments are listed inside a file.
- Ryan