It's not a matter of performance, it's a matter of complexity. More configurable does not always mean better.
- Trevor
On 9/29/10 3:46 PM, Maciej Jaros wrote:
Trevor Parscal wrote:
There seems to be some confusion about how ResourceLoader works, whichhas been leading people to make commits like r73196 and report bugs like #25362. I would like to offer some clarification.
ResourceLoader, if you aren't already aware, is a new system in MediaWiki 1.17 which allows developers to bundle collections of *resources* (like JavaScript and CSS files, or localized messages) into *modules*. Modules may represent any number of scripts, styles and messages, which are read from the file system, the database, or generated by software.
When a request is made for one or more modules, each resource is packaged together and sent back to the client as a response. The way in which these requests and responses are performed depends on whether debug is on or off.
When debug mode is off:
* Modules are requested in batches * Resources are combined into modules * Modules are combined into a response * The response is minifiedWhen debug mode is on:
* Modules are requested individually * Resources are combined into modulesI think it's debatable whether debug=true mode goes far enough, since it still combines resources into modules, and I am open to contributions that can make debug=true mode even more debugging friendly by delivering the resources to the client as unchanged as possible. I also think it's debatable if debug=false mode goes far enough, since things like Google Closure Compiler have been proven to even further reduce the size of JavaScript resources, so I am also open to contributions which can make debug=false even more production friendly by improving front-end performance.
I might be a little tired but are you saying that debug mode does not preserve original line numbers? So this is debug mode as in "a bit easier to debug in Firebug then fully minified code"?
And I still don't see how minification options are evil. One "if" won't really change performance.
Regards, Nux.
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l