simetrical@svn.wikimedia.org wrote:
$newminor . $sk->revComment( $this->mNewRev ) . "<br />" .
$newminor . $sk->revComment( $this->mNewRev, true ) . "<br />" .
Boolean parameters like this are a pain for code readability and maintainability; when you come back at the code later you won't remember what the heck "true" or "false" *means*.
Consider using a class constant with a descriptive name; maybe something like Linker::COMMENT_LOCAL_ANCHORS (or pick a better name ;)
-- brion vibber (brion @ pobox.com)