Simetrical schreef:
Okay, so can we ditch the setting user_name to $mName, at least? The only thing that should legitimately be saving changes to user_name is RenameUser, and that doesn't use User::saveSettings, it does a direct query. Anything saving changes to user_name is going to want to do a whole bunch of direct queries, anyway. The only problem is if someone, somewhere, in some broken extension, actually called setName() followed by saveSettings() and expected it to *work* (which the name of the method totally doesn't suggest, anyway).
Why don't we keep the 'current' settings around when they're load()ed and have saveSettings() check which settings changed (if any), and update only those?
Roan Kattouw (Catrope)