On 07/03/14 09:07, Chris McMahon wrote:
In over two years at WMF I have never been involved in a discussion like this, but here goes:
In this case, I think it was entirely appropriate to revert immediately and pick up the pieces later. The source of the code is immaterial, if Tim Starling or Brion Vibber had merged this we would have done exactly the same thing.
I would never have merged it, because it had a -1 from Steven Walling, apparently speaking on behalf of others on design-l. I think changes should be made by consensus.
On Gerrit, Bartosz Dziewoński wrote:
This has been silently reverted by Jon in https://gerrit.wikimedia.org/r/#/c/117234/ . I would appreciate leaving a comment here, or reverting through gerrit's interface instead of manually to do it automatically. It's not cool to do it like this.
I support this complaint. Please use the "revert" button in Gerrit to revert commits, or add a comment to the reverted change. A post to mobile-l is not sufficient.
-- Tim Starling