On Wed, Dec 21, 2011 at 12:01 AM, Brion Vibber bvibber@wikimedia.org wrote:
Often, little things are suitable for many people to look at, but major subsystem refactorings -- like the landing of Aaron's file backend changes -- really are specialized and need to be looked over by somebody who's a specialist, rather than just whoever gets around to looking it over.
I'd like us to seriously consider having primary reviewers for various code modules, so things like this get handled asap and don't end up falling through the cracks -- big changes, and small confusing changes ;) -- should get pretty consistently treated.
YES. I think I've proposed something like this before (a year ago?), but the people I talked to thought it would be unnecessary bureaucracy IIRC. I guess the CR situation has gotten sufficiently worse that we're finally considering this.
How about we set up a wiki page where we list who's an expert in what area (documenting this would be useful in its own right BTW), so we can figure out who'll be the primary reviewer for what, and put that on the wiki page too?
Roan